majomi/intro-skipper
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Explicitly define the undefined

Browse Source
This commit is contained in:
TwistedUmbrellaX 2024-03-17 19:04:57 -04:00
parent 5aeb33cdb9
commit 6619c48cde
1 changed files with 12 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
ConfusedPolarBear.Plugin.IntroSkipper/Configuration/configPage.html
View File

@ -749,20 +749,17 @@
canvas.style.display = "none"; canvas.style.display = "none";
lhs = await getJson("Intros/Episode/" + selectEpisode1.value + "/Chromaprint"); lhs = await getJson("Intros/Episode/" + selectEpisode1.value + "/Chromaprint");
rhs = await getJson("Intros/Episode/" + selectEpisode2.value + "/Chromaprint"); if (lhs === undefined) {
timestampError.value += "Error: " + selectEpisode1.value + " fingerprints failed!\n";
if (lhs === null) { } else if (lhs === null) {
timestampError.value += "Error: " + selectEpisode1.value + " fingerprints missing!\n"; timestampError.value += "Error: " + selectEpisode1.value + " fingerprints missing!\n";
} }
else if (lhs === undefined) {
timestampError.value += "Error: " + selectEpisode1.value + " fingerprints failed!\n";
}
if (rhs === null) { rhs = await getJson("Intros/Episode/" + selectEpisode2.value + "/Chromaprint");
timestampError.value += "Error: " + selectEpisode2.value + " fingerprints missing!\n";
}
if (rhs === undefined) { if (rhs === undefined) {
timestampError.value += "Error: " + selectEpisode2.value + " fingerprints failed!"; timestampError.value += "Error: " + selectEpisode2.value + " fingerprints failed!";
} else if (rhs === null) {
timestampError.value += "Error: " + selectEpisode2.value + " fingerprints missing!\n";
} }
if (timestampError.value == "") { if (timestampError.value == "") {
@ -787,12 +784,12 @@
const rightEpisode = selectEpisode2.options[selectEpisode2.selectedIndex]; const rightEpisode = selectEpisode2.options[selectEpisode2.selectedIndex];
// Try to get the timestamps of each intro, falling back a default value of zero if no intro was found // Try to get the timestamps of each intro, falling back a default value of zero if no intro was found
let leftEpisodeIntro = await getJson("Episode/" + leftEpisode.value + "/IntroTimestamps/v1"); let leftEpisodeIntro = await getJson("Episode/" + selectEpisode1.value + "/IntroTimestamps/v1");
if (!leftEpisodeIntro.hasOwnProperty("IntroStart")) { if (!leftEpisodeIntro.hasOwnProperty("IntroStart")) {
leftEpisodeIntro = { IntroStart: 0, IntroEnd: 0 }; leftEpisodeIntro = { IntroStart: 0, IntroEnd: 0 };
} }
let rightEpisodeIntro = await getJson("Episode/" + rightEpisode.value + "/IntroTimestamps/v1"); let rightEpisodeIntro = await getJson("Episode/" + selectEpisode2.value + "/IntroTimestamps/v1");
if (!rightEpisodeIntro.hasOwnProperty("IntroStart")) { if (!rightEpisodeIntro.hasOwnProperty("IntroStart")) {
rightEpisodeIntro = { IntroStart: 0, IntroEnd: 0 }; rightEpisodeIntro = { IntroStart: 0, IntroEnd: 0 };
} }
@ -837,7 +834,10 @@
return r.json(); return r.json();
} }
}) })
.catch(err => { console.debug(err); }); .catch(err => {
console.debug(err);
return undefined;
});
} }
// make an authenticated fetch to the server // make an authenticated fetch to the server