Aleksey
cfaa6a7d55
Apply suggestions from code review
...
Co-authored-by: David Howden <dhowden@gmail.com>
2021-09-19 16:23:20 +03:00
Aleksey Sulzhenko
b4ea69b945
Add comment with source
2021-09-19 13:27:37 +03:00
Aleksey Sulzhenko
42d38d7bfb
Added genre parsing for mp4 (atom) file metadata
2021-09-18 18:36:00 +03:00
David Howden
4b595ed4fa
check bounds in readAtomData
...
Fixes #78
2020-11-20 06:28:17 +11:00
David Howden
7e5c04fecc
move towards using uint for all sizes ( #59 )
...
* move towards using uint for all sizes
* dsf: support larger files
2019-11-22 22:50:59 +11:00
Steve Hellwege
db0c67e351
Issue 50 - mp4: multiple data atoms can cause size overflow and hang
2019-05-19 20:08:35 +10:00
Jonas L
34f7f1e3c8
Add comment metadata ( #44 )
2018-11-05 07:56:00 +11:00
David Howden
e80a3fa76a
update to use new io.Seek consts, require min go1.7
2018-04-02 11:06:41 +10:00
David Howden
d2206af145
mp4: fix panic on invalid encoding
2018-02-17 13:07:03 +11:00
David Howden
1582ebc2a4
mp4: fix panic on invalid encoding
...
Fixes #32
2018-02-07 18:36:47 +11:00
David Howden
737d3560dd
mp4: fix panic on invalid encoding
...
Fixes #31
2018-02-07 18:36:17 +11:00
David Howden
bccc91e40d
Fix: Detect PNG artwork when class = 0 (implicit) is set.
...
TODO: We should also try to detect JPEG artwork, but JPEG headers are a bit more tricky.
Fixes #19 .
2016-03-06 22:24:05 +11:00
David Howden
996bee7eb6
Fix panic when picture isn't properly parsed.
...
See issue #19 .
2016-03-05 16:17:11 +11:00
David Howden
a35ac09042
Distinguish between M4{A,B,P} formats.
...
Note: Removes tag.AAC.
2016-02-22 21:01:12 +11:00
David Howden
6df4e78d96
Remove non-relative Seek calls from all functions.
...
Previously we would seek to the beginning of the io.ReadSeeker. It is much more
flexible to assume that the caller passes the ReadSeeker in an appropriate state.
2015-06-07 12:58:58 +10:00
David Howden
d03fdf9fb5
Remove debugging output
2015-05-27 18:58:35 +10:00
David Howden
36d9163868
Refactored all MP4 code to better handle custom atoms
2015-05-27 08:43:47 +10:00
Xavier Henner
6c5d32240b
typo in comment + small correction
2015-05-25 08:57:37 +02:00
Xavier Henner
a931bf6e30
Code refactorization
...
Should even work if the subatoms of "----" are out of order
2015-05-25 08:45:31 +02:00
Xavier Henner
be3da62488
Add more tags to mp4
...
1) correct a bug with the mdat atom.
Sometimes, the metadata can be at the end, after the audio
Demo :
get any music file and strip the metadata
convert it to m4a with ffmpeg
analyse it with MusicBrainz Picard
et voila, you have the metadata at the end.
Example of structure of a m4a created that way;
https://www.dropbox.com/s/602yivdstan7506/atom.txt?dl=0
2) add support for the "----" tag
See http://atomicparsley.sourceforge.net/mpeg-4files.html
It gives access to the tags created by MusicBrainz Picard
2015-05-25 00:33:47 +02:00
David Howden
4c2b34fa94
Reorganised Vorbis Comment parsing into own type
...
- Added FileType to Metadata to distinguish between FLAC and OGG
- TODO: fix ALAC files being identified as AAC
2015-05-24 10:44:45 +10:00
Xavier Henner
0f62dc116a
Add support for lyrics.
...
Not supported in id3v1 and id3v22
2015-05-19 22:06:16 +10:00
David Howden
c895efbcf8
Revert "Add support for lyrics."
2015-05-19 08:03:36 +10:00
Xavier Henner
7fac753a70
Add support for lyrics.
...
Not supported in id3v1 and id3v22
2015-05-18 09:32:54 +02:00
David Howden
8aff503453
Use Seek instead of discardN
2015-04-15 00:12:30 +10:00
David Howden
1fc6cacf34
Updated ReadFrom to take io.ReadSeeker
2015-04-15 00:06:32 +10:00
David Howden
9278a7ec07
Initial commit
2015-03-19 23:21:53 +11:00